nestjs / nest

A progressive Node.js framework for building efficient, scalable, and enterprise-grade server-side applications with TypeScript/JavaScript 🚀
https://nestjs.com
MIT License
67.29k stars 7.59k forks source link

grpc-loader not able to load well-knows-photos like google/protobuf/wrappers.proto #4584

Closed xmlking closed 4 years ago

xmlking commented 4 years ago

Bug Report

@grpc/proto-loader was not able to load well-knows-photos like google/protobuf/descriptor.proto etc this was working before.

Current behavior

(node:88142) Warning: google/protobuf/wrappers.proto not found in any of the include paths /Users/schintha/Developer/Work/SPA/yeti/dist/apps/api/proto
(node:88142) Warning: google/protobuf/descriptor.proto not found in any of the include paths /Users/schintha/Developer/Work/SPA/yeti/dist/apps/api/proto
(node:88142) Warning: google/protobuf/duration.proto not found in any of the include paths /Users/schintha/Developer/Work/SPA/yeti/dist/apps/api/proto
(node:88142) Warning: google/protobuf/timestamp.proto not found in any of the include paths /Users/schintha/Developer/Work/SPA/yeti/dist/apps/api/proto
(node:88142) Warning: google/protobuf/empty.proto not found in any of the include paths /Users/schintha/Developer/Work/SPA/yeti/dist/apps/api/proto
(node:88142) Warning: google/protobuf/wrappers.proto not found in any of the include paths /Users/schintha/Developer/Work/SPA/yeti/dist/apps/api/proto

Input Code

git clone https://github.com/xmlking/yeti.git cd yeti

ng serve api

Expected behavior

Should have no loading Warnings

Possible Solution

Environment


Nest version: 7.1.2


For Tooling issues:
- Node version: v13.12.0  
- Platform:  Mac 

Others:

kamilmysliwiec commented 4 years ago

Please, use StackOverflow for such questions. We are using GitHub to track bugs, feature requests, and potential improvements.

xmlking commented 4 years ago

This was working in the previous nestjs release. I guess some recent updates in proto-loader, grpc npm packages may be causing this issue. I suspect it is a regression issue.

daniel-vera-g commented 3 years ago

This was working in the previous nestjs release. I guess some recent updates in proto-loader, grpc npm packages may be causing this issue. I suspect it is a regression issue.

Hey @xmlking, were you able to fix this and load the well-knows types?

My current workaround is to have the needed types locally so the proto-loader finds them.