search

nestjs / nest

A progressive Node.js framework for building efficient, scalable, and enterprise-grade server-side applications with TypeScript/JavaScript 🚀
https://nestjs.com
MIT License
67.28k stars 7.59k forks source link

[nestjs-grpc] max_pings_without_data cannot set to 0 #4816

Closed Jekiwijaya closed 4 years ago

Jekiwijaya commented 4 years ago

Bug Report

Current behavior

http2MaxPingsWithoutData: 0 is ignored, my app sometimes always return too many pings

Input Code

I think because of this https://github.com/nestjs/nest/blob/master/packages/microservices/client/client-grpc.ts#L128

Expected behavior

if (key === undefined) {
    continue;
}

Environment


Nest version: ^6.13.2


For Tooling issues:
- Node version: v10.16.1
- Platform:  Linux

Others:
kamilmysliwiec commented 4 years ago

Fixed in 7.1.0.