search

nestjs / nest

A progressive Node.js framework for building efficient, scalable, and enterprise-grade server-side applications with TypeScript/JavaScript 🚀
https://nestjs.com
MIT License
67.28k stars 7.59k forks source link

Upgrading from grpc to @grpc/grpc-js #5227

Closed davidhuang1550 closed 4 years ago

davidhuang1550 commented 4 years ago

Feature Request

Is your feature request related to a problem? Please describe.

I am currently using NestJS Microservices v7.4.2 which is dynamically requiring GRPC lib for ClientGrpcProxy. However, GRPC lib is being deprecated. The new version grpc-js is going to replace regular grpc. After switching to grpc-js, I am encountering package loader exceptions due to the dynamic loading of old grpc. Is there going to be an update on this to be able to use the new version of grpc-js? or is there a workaround for this?

Issue when using @Grpc/grpc-js

'The "grpc" package is missing. Please, make sure to install this library ($ npm install grpc) to take advantage of ClientGrpcProxy.'

Issue

Deprecation notice to package: https://www.npmjs.com/package/grpc

Describe the solution you'd like

Solution

dynamically require new version of grpc or have this configurable

Teachability, Documentation, Adoption, Migration Strategy

N/A

What is the motivation / use case for changing the behavior?

Issue when using new version of @grpc/grpc-js

davidhuang1550 commented 4 years ago

just noticed the duplicate to

https://github.com/nestjs/nest/issues/4799

is there a target date for the new version?

kamilmysliwiec commented 4 years ago

is there a target date for the new version?

Unfortunately, not yet. Switching to a different package is a breaking change, so we must wait till the next major release. We'll keep you informed!

Let's track this here #4799