nestjs / nestjs.com

The official website https://nestjs.com 🏆
https://nestjs.com
MIT License
137 stars 23 forks source link

StackBlitz src/app.controller.spec.ts `getHello` unit test failing #77

Closed jremi closed 1 year ago

jremi commented 1 year ago

The landing page of nestjs.com website has a live preview running in StackBlitz.

The src/app.controller.spec.ts unit test is failing: https://stackblitz.com/edit/nestjs-typescript-starter-pcysqn?file=src%2Fapp.controller.spec.ts

Currently:

describe('getHello', () => {
    it('should return "Hello World!"', () => {
      const appController = app.get<AppController>(AppController);
       // NOTE: Attempting to access the getHello() service method directly (does not exist on appController).
       expect(appController.getHello()).toBe('Hello World!');
    });
});

Suggested change:

describe('getHello', () => {
    it('should return "Hello World!"', () => {
      const appController = app.get<AppController>(AppController);
      // NOTE: Change the expect to check for valid object response using render() method
      expect(appController.render()).toEqual({ message: 'Hello World!' });
    });
});
kamilmysliwiec commented 1 year ago

Fixed