nestjs / newsletter.nestjs.com

Official NestJS Newsletter website https://newsletter.nestjs.com 📩
MIT License
11 stars 0 forks source link

Newsletter form enhancements #2

Open DeepaPrasanna opened 2 months ago

DeepaPrasanna commented 2 months ago
  1. Not able to realise that the form submitted successfully. Suggestion: Maybe a text "subscribed" on the disabled button would be appropriate to show after successful submission.

  2. Giving same email again doesn't shows anything on the UI but shows a bad request error in the network tab. Suggestion: To show a proper error message below the button regarding this, maybe text like "something went wrong!"

    Please check the attached screenshots. Screenshot1 screenshot2

    Please let me know if you have anything else in your mind regarding this! I would like to take up this issue. Thanks!

ualiusman commented 2 weeks ago

What I suggest, request should be successful with response like 'this email already subscribed' message can be display even response is bad request.