search

nestjs / terminus

Terminus module for Nest framework (node.js) :robot:
https://nestjs.com/
MIT License
675 stars 100 forks source link

Package is missing HttpHealthIndicator #1220

Closed JVMartin closed 3 years ago

JVMartin commented 3 years ago

I'm submitting a...


[ ] Regression 
[X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Package no longer exports an HttpHealthIndicator.

import { HealthCheck, HealthCheckService, HttpHealthIndicator, TypeOrmHealthIndicator } from '@nestjs/terminus';

Results in:

src/api/controllers/health.controller.ts:2:43 - error TS2724: Module '"../../../node_modules/@nestjs/terminus/dist"' has no exported member 'HttpHealthIndicator'. Did you mean 'GRPCHealthIndicator'?

2 import { HealthCheck, HealthCheckService, HttpHealthIndicator, TypeOrmHealthIndicator } from '@nestjs/terminus';
                                            ~~~~~~~~~~~~~~~~~~~

  node_modules/@nestjs/terminus/dist/health-indicator/microservice/grpc.health.d.ts:28:22
    28 export declare class GRPCHealthIndicator extends HealthIndicator {
                            ~~~~~~~~~~~~~~~~~~~
    'GRPCHealthIndicator' is declared here.

Expected behavior

Package should export an HttpHealthIndicator, as signified in the documentation here: https://docs.nestjs.com/recipes/terminus

Minimal reproduction of the problem with instructions

Using package.json:

    "@nestjs/terminus": "^7.0.1",
BrunnerLivio commented 3 years ago

Thanks for your submission. The HTTPHealthIndicator has been introduced in 7.1.0, please upgrade or use the DNSHealthIndicator in 7.0.1 (identical implementation - though will be removed in 8.x.x)