nestjs / terminus

Terminus module for Nest framework (node.js) :robot:
https://nestjs.com/
MIT License
675 stars 100 forks source link

Incompatible with nestjs v7 #606

Closed BenWildeman closed 4 years ago

BenWildeman commented 4 years ago

I'm submitting a...


[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When using nestjs v7, eslint will throw errors about not being able to find microservice-configuration.interface

Expected behavior

to work with v7

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Nest version: 7.0.5


For Tooling issues:
- Node version: All compatible
- Platform:  All

Others:

BrunnerLivio commented 4 years ago

Duplicate of #596 and #594. I’ll keep this one open so no new issues ahout this will get created.

7.0.0 compatibility is on the way, check out #593

hazzo commented 4 years ago

Hi got one question: installing the new terminus version and running the server displays the following errors:

node_modules/@nestjs/terminus/dist/health-indicator/database/typeorm.health.d.ts:1:33 - error TS2307: Cannot find module 'typeorm'.

1 import type { Connection } from 'typeorm';
                                  ~~~~~~~~~

node_modules/@nestjs/terminus/dist/health-indicator/microservice/grpc.health.d.ts:1:34 - error TS2307: Cannot find module '@nestjs/microservices'.

1 import type { GrpcOptions } from '@nestjs/microservices';
                                   ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@nestjs/terminus/dist/health-indicator/microservice/microservice.health.d.ts:1:93 - error TS2307: Cannot find module '@nestjs/microservices'.

1 import { GrpcOptions, MqttOptions, NatsOptions, RedisOptions, RmqOptions, TcpOptions } from '@nestjs/microservices';

Terminus needs @nestjs/microservices and typeorm?? If so, they not seem to appear in the package-lock.json as required dependencies.

BrunnerLivio commented 4 years ago

@hazzo still need to fix that, at the moment you will need to add ”skipLibCheck”: true in your tsconfig to bypass that

hazzo commented 4 years ago

Okey cool thanks. I solved meanwhile by adding the corresponding dependencies.

BrunnerLivio commented 4 years ago

Resolved in 7.0.0 :tada:

@hazzo also the skipLibCheck is now resolved