search

nestjs / typescript-starter

Nest framework TypeScript starter :coffee:
https://nestjs.com
1.89k stars 1.07k forks source link

Remove eslint-plugin-prettier and Enable eslint-config-prettier #302

Closed y-hsgw closed 3 weeks ago

y-hsgw commented 4 months ago

Hi!🖐️ I would like to propose two changes.

  1. Remove eslint-plugin-prettier: As per the official Prettier documentation, the prettier --check . command can be used instead, so eslint-plugin-prettier may no longer be necessary.
  2. Enable eslint-config-prettier: As per the official documentation, it seems that prettier is not specified in the extends section. How about enabling this configuration? This will disable ESLint rules that conflict with Prettier, ensuring a smoother development experience.

Please verify my understanding, as there may be some discrepancies. If everything looks good, I would like to proceed with creating a PR.

kamilmysliwiec commented 3 weeks ago

This is going to change once we migrate to v9 https://github.com/nestjs/typescript-starter/pull/310