Open hakimio opened 3 years ago
I am tempted to fork it and merge all the fixes that everyone is waiting on, but it would be better to be able to help to develop this library on this repo.
Can I become a contributor?
I kind of thought this would eventually go into the Nestjs organization. Im interested in the future of this package as well.
@Jtosbornex Since @zMotivat0r just recently joined "Trilon" (the company behind NestJS) and there is a lot of interest in the library from the community, I think it's quite possible of it becoming part of official NestJS organization.
@hakimio Really hope so. This is a great library!
Hi guys! Thanks a lot for raising this issue and I would definitely love to have you guys (or some of you who may be really interested) as maintainers of this library. I really appreciate this and hope with your help we won't let this lib just die. Due to some really complex family conditions, I can't afford to spend as much time on it as I did in the past, but I don't want to completely bury this lib. So, yeah @rewiko your propositions came out with just perfect timing.
Going forward, I've raised some amount of money via open collective and hadn't spend anything, so I definitely would love to share those with new maintainers as well
@zMotivat0r what do you think about the idea of making this library part of NestJS organization (if @kamilmysliwiec accepts)?
@hakimio we had a conversation about it (a couple of times tbh) and a strong argument against adding it to NestJs (and I totally agree with it) is that this lib is not totally following community convention on how to provide this kinda functionality. I.e. I build it to use @Crud
decorator and pass all the params there in the first place, but another and perhaps the best way to do it to use mixins. So maybe when we have mixins, plus CrudModule with forRoot
with global config instead of what we have now, plus CrudModule with forFeature
for controllers auto-generation or just a per-module configuration, then we could make another proposal to @kamilmysliwiec :)
Thanks @zMotivat0r for getting back to us, hope your family is ok and your problems are going to be resolved.
Happy to spend some time to at least create a new release with all the bug fixes waiting to be merged.
@rewiko added you as a maintainer
@zMotivat0r mixin idea theoretically seems really good, but in practice there seems to be some issues implementing it. If those could be solved, I would love to use mixin approach as well.
OT: right now all the ORM (type-orm, mikro-orm, mongoose, etc) integrations have to be added to this repository since some "core" logic is not accessible otherwise. What do you think about splitting integration core code and the integration itself into separate packages, so that people could maintain their integrations in 3rd party repositories independent from the core library?
BTW, it might make sense to make @Diluka collaborator of this repository since he contributed a lot of code already.
This is a great NestJS library and it would be wonderful to see it at least maintained. I would be happy to help out. I use it on some production projects and it is really super helpful!
@zMotivat0r I would be happy to contribute.
Maybe we could start by creating a package roadmap in Github Projects.
@rewiko any updates regarding reanimating the package ?
I can merge PR, but I don't know how to create a new release (new credentials..), I asked @zMotivat0r we would potentially use mrepo to automate the release process.
mrepo
May I propose using https://github.com/atlassian/changesets for managing releases?
@rewiko Please any updates on this thread ?
there are a lot of pending PRs
some of are just silly things for ex: I have // @ts-ignore
all over my controllers
in
@Crud({
// ....
join: {
xxxxx: {
// @ts-ignore <-------------
select: true,
eager: true,
},
just because of the type https://github.com/nestjsx/crud/pull/713
and so one ...
so Please would you put time into it or let who is interrested to do so,
thank you for understanding, and for the good job, we are just caring about the package to not die
@tarekbazine @rewiko as mentioned above doesn't have permissions to create new releases.
@hakimio I do not see the permissions thing mentioned in the thread, but even though we need to solve this since the package is inactive since months.
any suggestion ? we maintain a fork ? @rewiko @zMotivat0r
Any updates on this? What is the problem with the releases @rewiko? Is it a permissions thing or just choosing the right tool?
@zMotivat0r can you please help him with this? I'm also offering to help out if you need me. This is a great library and would be a shame for it to die over this.
Please! any update on this? people are offering to help
we just need to know what is the blocker here.
This library is a crucial part of my stack and one of the most important modules for any Nest.js REST API. It'd be amazing to have this resolved asap, I'd be willing to support this also financially if it gains momentum again.
Any progress? What's the blocker currently?
Looks like @zMotivat0r just gave up on this library and there won't be any further development.
Shall we fork this then? There are so many valuable PRs out there...
I also want to help, @zMotivat0r gave me access to the repo so I can merge PR, but I do not have access to the NPM repo to publish the lib (the release is not automated). I spoke to @zMotivat0r 6 month ago, and he was keen to automate the release with https://github.com/zMotivat0r/mrepo.
I think we should try to automate the release, I guess for now we should fork it, automate the release and merge all the valuable PRs.
@codepushr would you be happy to help ? (I will spend time too)
I managed to migrate and publish the lib under my username on npm and github. I am happy to create a generic repo if needed otherwise, we can migrate PR and merge them.
list of PR merged https://github.com/rewiko/crud/issues/5
@rewiko Thank you very much. Please keep up the good work. IMO you can continue merging PR while trying to contact @zMotivat0r for deployment access. I still want to see a new version of this package under its original name as we don't want the users of this lib fragmented.
Maybe the development of this essential package could continue here?
@zMotivat0r do you plan to maintain this library? Is it worth starting new integrations (ie mikro-orm, firestore, sequelize, mongoose)? Do you have some plan what you'd like to do with the library?