fix(crud-typeorm): fix duplicate column names when using limit parameter

zetti-caletti commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message was generated by yarn commit
[ ] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Tests
[ ] Release
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

When using limit parameter on getMany() and eager loading of nested entities the query failed because of duplicate column names. Primary columns where selected twice.

Issue Number: N/A

What is the new behavior?

Now all the column names are made unique so that no duplicate column names occur.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

DanielUche commented 2 years ago

This error still persists

streetlogics commented 1 year ago

@michaelyali @fwoelffel @rjpkuyper - any chance one of you can take a look at this and merge / release this PR? I also have this commit merged into my fork's master with these merge conflicts resolved - https://github.com/streetlogics/nestjsx-crud/commit/e9dc932e1e5fc836f2073cbf5071434e87f27af0 . Anything to get this working would be amazing!

afilp commented 1 year ago

@zetti-caletti This repo seems to not be supported anymore, would you like to submit your PR to the following forked repo, which is more up-to-date? Thanks!

https://github.com/gid-oss/dataui-nestjs-crud

nestjsx / crud