search

nestlabs / nlbuild-autotools

The Nest Labs Build - GNU Autotools (nlbuild-autotools) provides a customized, turnkey build system framework, based on GNU autotools, for standalone Nest Labs (or other) software packages that need to support not only building on and targeting against standalone build host systems but also embedded target systems using GCC-based or -compatible toolchains.
Apache License 2.0
4 stars 12 forks source link

install-headers target should depend on BUILT_SOURCES #24

Closed robszewczyk closed 5 years ago

robszewczyk commented 5 years ago

Quoting from https://www.gnu.org/software/automake/manual/html_node/Sources.html

BUILT_SOURCES is actually a bit of a misnomer, as any file which must
be created early in the build process can be listed in this
variable. Moreover, all built sources do not necessarily have to be
listed in BUILT_SOURCES. For instance, a generated .c file doesn’t
need to appear in BUILT_SOURCES (unless it is included by another
source), because it’s a known dependency of the associated object.

The documentation for BUILT_SOURCES repeatedly states that the it specifies the sources that need to be built early in the build process and that make all, make check and make install all depend on BUILT_SOURCES. Given the strong parallels between those commands and make install-headers we argue that introducing this dependency is a reasonable step in enforcing the logical consistency of the build system.

gerickson commented 5 years ago

Looks good. Please update .default-version (this is a patch '.Z' bump), add a CHANGELOG entry, and make and push a tag as well.

robszewczyk commented 5 years ago

Looks good. Please update .default-version (this is a patch '.Z' bump), add a CHANGELOG entry, and make and push a tag as well.

Updated the PR. I have no rights to this repo, so could you approve and merge?