search

nestybox / sysbox-pkgr

Sysbox-pkgr repository
5 stars 14 forks source link

Fix sysbox install compatibility with GKE #111

Closed yachub closed 1 year ago

yachub commented 1 year ago

Fixes https://github.com/nestybox/sysbox/issues/680

Thanks @jamonation for finding the manual fix at https://github.com/nestybox/sysbox/issues/680#issuecomment-1528597856, so this should implement those changes for GKE users. Although, it seems fine to leave the loopback CNI at /etc/cni/net.d/200-loopback.conf

I used the following steps to build the container on this branch locally, pushed to a local mirror, and deployed to GKE (running GKE 1.24.14-gke.1400 - Ubuntu with containerd node pool) resolving our issue:

I have not tested on any other platforms or versions.

Happy to take suggestions and re-test if needed.

ctalledo commented 1 year ago

Hi Jake (@yachub), it seems this other pending PR does the exact same thing as yours, although it has a slightly improved way to check for GKE.

Could you take a look and confirm?

My apologies, I did not remember that this other pending PR was there already. If it looks good, I'll merge that other one and we can archive this one. Thanks!

yachub commented 1 year ago

Hi Jake (@yachub), it seems this other pending PR does the exact same thing as yours, although it has a slightly improved way to check for GKE.

Could you take a look and confirm?

My apologies, I did not remember that this other pending PR was there already. If it looks good, I'll merge that other one and we can archive this one. Thanks!

Oops, can't believe I didn't see that. Yes, I'll build and deploy this locally and confirm.

ctalledo commented 1 year ago

Hi @yachub,

As discussed, closing this in favor of https://github.com/nestybox/sysbox-pkgr/pull/108.

Thank you very much though for the effort in this PR.