search

nestybox / sysbox-pkgr

Sysbox-pkgr repository
5 stars 14 forks source link

Support custom taint #124

Closed raphaelfff closed 6 months ago

raphaelfff commented 6 months ago

Closes #117

This would allow one to set SYSBOX_TAINT=startup-taint.cluster-autoscaler.kubernetes.io/sysbox-runtime=not-running:NoSchedule Which would let GKE know whats going on

raphaelfff commented 6 months ago

@ctalledo When can we expect the next release containing that ?

ctalledo commented 6 months ago

I can generate that this week, since sysbox-deploy-k8s improvements / releases can be done async from Sysbox releases.

ctalledo commented 6 months ago

@ctalledo When can we expect the next release containing that ?

Done! Give it a try and let me know if it works ... thanks!

raphaelfff commented 6 months ago

What tag should i use for the image? registry.nestybox.com/nestybox/sysbox-deploy-k8s:v0.6.5 ?

ctalledo commented 6 months ago

No it's still v0.6.4 (the version of Sysbox has not changed, we've only improved the K8s installation daemonset) ...

raphaelfff commented 6 months ago

But i changed sysbox-deploy-k8s.sh , which is part if the image, so i need a new image with that change, right ?

ctalledo commented 6 months ago

Sorry for the confusion. We tag sysbox-deploy-k8s according to the version of the Sysbox binary that they carry (e.g., v0.6.4). In this case the Sysbox binary has not changed. We've only changed the k8s installer for that binary. Thus the new image has the same tag. It's equivalent to making a change in an installer for a product, without changing the version of the product itself.

raphaelfff commented 6 months ago

oh, so 0.6.4 now has the updated script ? I see... will play around with it and let you know how it goes

ctalledo commented 6 months ago

oh, so 0.6.4 now has the updated script

Yes exactly ...

I see... will play around with it and let you know how it goes

Yes please, and let me know if you find any issues, I've not tested the custom taints myself.