nestybox / sysbox

An open-source, next-generation "runc" that empowers rootless containers to run workloads such as Systemd, Docker, Kubernetes, just like VMs.
Apache License 2.0
2.78k stars 152 forks source link

Sysbox 0.6.1 the K8S installer for 1.22 is missing crio-patched binary #676

Closed vandycknick closed 1 year ago

vandycknick commented 1 year ago

While installing the latest sysbox version (0.6.1) on a clean K8S cluster running v1.22. I ran into the following issue:

Detected Kubernetes version v1.22
Adding K8s taint "sysbox-runtime=not-running:NoSchedule" to node ...
node/192-168-56-11--node modified
Adding K8s label "crio-runtime=installing" to node ...
node/192-168-56-11--node not labeled
Deploying CRI-O installer agent on the host (v1.22) ...
cp: cannot stat '/opt/crio-deploy/bin/v1.22/crio-patched': No such file or directory

The patched crio binary for v1.22 is missing:

Screenshot 2023-04-17 at 14 50 03

ctalledo commented 1 year ago

Hi @vandycknick, installation of Sysbox on K8s v1.22 is no longer supported (v1.22 is EOL'd).

vandycknick commented 1 year ago

Thanks for the update. That wasn't immediately obvious to me. The installer script already has a check to see if the k8s version is compatible. It might be nice to add the v1.22 version to the not supported list here aswell 😄

function is_supported_k8s_version() {

        local ver=$k8s_version

        if [[ "$ver" == "v1.22" ]] ||
                [[ "$ver" == "v1.23" ]] ||
                [[ "$ver" == "v1.24" ]] ||
                [[ "$ver" == "v1.25" ]] ||
                [[ "$ver" == "v1.26" ]]; then
                return
        fi

        if [[ "$ver" == "v1.19" ]] ||
                [[ "$ver" == "v1.20" ]] ||
                [[ "$ver" == "v1.21" ]]; then
                echo "Unsupported kubernetes version: $ver (EOL release)."
        fi

        false
}

I would make a PR but have no idea where this script is managed.

ctalledo commented 1 year ago

Oh thanks for catching that, I'll fix it.

I would make a PR but have no idea where this script is managed.

We will be open-sourcing that code very soon (in the coming days).