search

nestybox / sysbox

An open-source, next-generation "runc" that empowers rootless containers to run workloads such as Systemd, Docker, Kubernetes, just like VMs.
Apache License 2.0
2.78k stars 152 forks source link

Sysbox build attributes missing from "--version" output #73

Closed myugan closed 3 years ago

myugan commented 4 years ago

I following the guide from here https://github.com/nestybox/sysbox/blob/master/docs/developers-guide/build.md, download the source code from the release page but it's failed when try to run make sysbox like this:

OS version: Ubuntu 18.04.5 LTS Kernel version: 5.4.0-48-generic #52~18.04.1-Ubuntu SMP

** Building sysbox **

docker run --privileged --rm --hostname sysbox-build --name sysbox-build -v /root/sysbox-0.2.1:/root/nestybox/sysbox -v /root/go/pkg/mod:/go/pkg/mod -v /lib/modules/5.4.0-48-generic:/lib/modules/5.4.0-48-generic:ro -v /usr/src/:/usr/src/:ro -v /usr/src/:/usr/src/:ro sysbox-test /bin/bash -c "buildContainerInit sysbox-local"
cd sysbox-runc && make clean
make[1]: Entering directory '/root/nestybox/sysbox/sysbox-runc'
make[1]: Leaving directory '/root/nestybox/sysbox/sysbox-runc'
make[1]: *** No rule to make target 'clean'.  Stop.
Makefile:325: recipe for target 'clean' failed
make: *** [clean] Error 2
Makefile:110: recipe for target 'sysbox' failed
make: *** [sysbox] Error 2
rodnymolina commented 4 years ago

@myugan, are you sure that you git-clone Sysbox making use of the "--recursive" flag as indicated in our doc? (we have various repos within Sysbox project).

git clone --recursive git@github.com:nestybox/sysbox.git

Let me know if any problem.

myugan commented 4 years ago

Okay, I guess the source code will contain all of the code instead of --recursive flag using git command, and now it's working but when I try sysbox-runc -v there is and output only at oci-specs like this:

sysbox-runc
        version:
        commit:
        built at:
        built by:
        oci-specs:      1.0.2

is that ok? because there is an issue when I use sysbox-runc from docker api.

Sep 25 09:09:14 hostname dockerd[12343]: time="2020-09-25T09:09:14.807365273Z" level=debug msg="EnableService a021f6d95ae74d1f45797dac92fb140e9a9be2ec8c0c1faa09201ef8e94bf4ea START"
Sep 25 09:09:14 hostname dockerd[12343]: time="2020-09-25T09:09:14.807423415Z" level=debug msg="EnableService a021f6d95ae74d1f45797dac92fb140e9a9be2ec8c0c1faa09201ef8e94bf4ea DONE"
Sep 25 09:09:14 hostname dockerd[12343]: time="2020-09-25T09:09:14.818002083Z" level=debug msg="bundle dir created" bundle=/var/run/docker/containerd/a021f6d95ae74d1f45797dac92fb140e9a9be2ec8c0c1faa09201ef8e94bf4ea module=libcontainerd namespace=moby root=/var/lib/docker/overlay2/be1f7535b1032b43fc16b57fe242443ea356b9cc2ddcf9a2524547962a47c0ed/merged
Sep 25 09:09:14 hostname dockerd[12343]: time="2020-09-25T09:09:14.969519449Z" level=debug msg="Calling GET /v1.25/info"
Sep 25 09:09:14 hostname dockerd[12343]: time="2020-09-25T09:09:14.989310216Z" level=debug msg="Calling GET /v1.25/info"
Sep 25 09:09:14 hostname dockerd[12343]: time="2020-09-25T09:09:14.999037218Z" level=warning msg="failed to parse /usr/local/sbin/sysbox-runc version: unknown output format: sysbox-runc\n\tversion: \t\n\tcommit: \t\n\tbuilt at: \t\n\tbuilt by: \t\n\toci-specs: \t1.0.2\n"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.006462835Z" level=debug msg="Calling GET /v1.25/containers/a021f6d95ae74d1f45797dac92fb140e9a9be2ec8c0c1faa09201ef8e94bf4ea/json"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.018008708Z" level=warning msg="failed to parse /usr/local/sbin/sysbox-runc version: unknown output format: sysbox-runc\n\tversion: \t\n\tcommit: \t\n\tbuilt at: \t\n\tbuilt by: \t\n\toci-specs: \t1.0.2\n"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.020806362Z" level=debug msg="Calling GET /v1.25/containers/json?all=1&filters=%7B%22id%22%3A%7B%22a021f6d95ae74d1f45797dac92fb140e9a9be2ec8c0c1faa09201ef8e94bf4ea%22%3Atrue%7D%7D&limit=0"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.079136977Z" level=debug msg="Calling GET /v1.24/containers/a021f6d95ae7/json"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.235146380Z" level=debug msg="Calling GET /v1.25/info"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.274484866Z" level=warning msg="failed to parse /usr/local/sbin/sysbox-runc version: unknown output format: sysbox-runc\n\tversion: \t\n\tcommit: \t\n\tbuilt at: \t\n\tbuilt by: \t\n\toci-specs: \t1.0.2\n"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.276421934Z" level=debug msg="Calling GET /v1.25/containers/json?all=1&filters=%7B%22id%22%3A%7B%22a021f6d95ae74d1f45797dac92fb140e9a9be2ec8c0c1faa09201ef8e94bf4ea%22%3Atrue%7D%7D&limit=0"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.295354135Z" level=error msg="stream copy error: reading from a closed fifo"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.303465896Z" level=debug msg="Revoking external connectivity on endpoint ubuntu-gikvhrrw (e0c46d32717c66b45934542f7aebb7bae7b36833c22e78d069047728e8233676)"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.305772119Z" level=debug msg="/sbin/iptables, [--wait -t nat -C DOCKER -p tcp -d 0/0 --dport 32773 -j DNAT --to-destination 172.25.1.2:8080 ! -i br-9284dc0deaa1]"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.308085046Z" level=debug msg="/sbin/iptables, [--wait -t nat -D DOCKER -p tcp -d 0/0 --dport 32773 -j DNAT --to-destination 172.25.1.2:8080 ! -i br-9284dc0deaa1]"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.311037503Z" level=debug msg="/sbin/iptables, [--wait -t filter -C DOCKER ! -i br-9284dc0deaa1 -o br-9284dc0deaa1 -p tcp -d 172.25.1.2 --dport 8080 -j ACCEPT]"
Sep 25 09:09:15 hostname dockerd[12343]: time="2020-09-25T09:09:15.313115798Z" level=debug msg="/sbin/iptables, [--wait -t filter -D DOCKER ! -i br-9284dc0deaa1 -o br-9284dc0deaa1 -p tcp -d 172.25.1.2 --dport 8080 -j ACCEPT]"
rodnymolina commented 4 years ago

Thanks @myugan, you have encountered a bug in our build-infrastructure logic, which is preventing these attributes (version/commit/build-at, etc) from being properly passed to the sysbox builder container. This was probably introduced a few weeks ago when we made some Makefile changes.

However, please keep in mind that none of this will impact Sysbox functionality, as we are dealing with a cosmetic issue here.

Btw, I'll go ahead and adjust this issue's title to reflect the problem that you just found. Please change it if you find a better title.

ctalledo commented 4 years ago

Hi @myugan,

However, please keep in mind that none of this will impact Sysbox functionality, as we are dealing with a cosmetic issue here.

Do you agree with @rodnymolina comment here? Or is this more than a cosmetic issue for you?

myugan commented 4 years ago

I'm agreed @ctalledo

ctalledo commented 4 years ago

Thanks @myugan ; let's leave the issue open and we will get to it soon (we definitely want to fix it). In the meantime let us know of any other issue you hit, we appreciate you trying Sysbox.

ctalledo commented 3 years ago

This was fixed back in 01/2021 and will be present in the upcoming 0.3.0 release.

root@sysbox-test:~/nestybox/sysbox# sysbox-runc --version
sysbox-runc
        version:        0.3.0-dev
        commit:         "0e845604d5f62365825df03b305f18eb706ccbb5"
        built at: 
        built by: 
        oci-specs:      1.0.2-dev
root@sysbox-test:~/nestybox/sysbox# sysbox-fs --version
sysbox-fs
        version:        0.3.0-dev
        commit:         "4fe6862a6d2114827f4977959b683101bf90a252"
        built at: 
        built by: 
root@sysbox-test:~/nestybox/sysbox# sysbox-mgr --version
sysbox-mgr
        version:        0.3.0-dev
        commit:         "95010ecb3e813d75ec8b523bd8f6d8890dfa26e6"
        built at: 
        built by:
ctalledo commented 3 years ago

Closing.