Closed tovarm-uchi closed 3 years ago
coding style: don't forget that we're conforming to the StandardJS coding style. if u haven't already i suggest adding the standard plugin to ur editor so u can lint ur js files as u work. there are lots of linting/style issues in ur JavaScript files.
I did my best to get away all the lint warnings, however there were a couple I have not been able to address.
const create = new p5(createPad, 'create') const test = new p5(testPad,
'test')`
currently these two lines, no matter the variation I have tried to make it in there is some sort of error. Right now its the unused variable and that p5 should be uppercase but when I remove the variables it says no side effects with just the new and well without the new there is no warning but the canvas are not created.
reorganize code: u've got global variables being declared throughout ur main.js function, to keep the code a bit more readable it's best to declare all the global variables at the top of the file
I think I addressed this, especially by moving and creating new files
function syntax: at the moment u're mixing function declaration styles in ur global code. sometimes u do
const name = function ()
other timesfunction name ()
, both are valid, but for readability it's best to pick one && keep ur code consistent.
I think most of this was also resolved, especially in the new way I declare the createPad and testPad