search

net-art-uchicago / cta-file-sharing

a collaborative artware project by Media Art and Design students at the University of Chicago.
GNU General Public License v3.0
2 stars 15 forks source link

Page2 #18

Closed aureliejr closed 1 year ago

aureliejr commented 1 year ago

extremely basic html page that displays given JSON formatted poems

aureliejr commented 1 year ago

I changed things based on the comments you left + tried to fix some other issues with my code. The problem I'm running into now is either with the ".length" function or my actual JSON file, but for some reason the code seems to be detecting that there's only one object in my JSON file. I'll make the HTML/JS more interesting/better once I can get this working. Apologies for the delay.

Also: I'm not sure if this is the right way to update a PR, please let me know if there's something else I need to do

nbriz commented 1 year ago

@aurelieschool u don't need to close / reopen the PR, u can leave it open while u're making these changes.

what u do need to do though is push the edits u've made up to ur repo so that this PR gets updated w/those new changes && i can pull + test them on my end

aureliejr commented 1 year ago

I updated the poems file to fit the new JSON formatting. Also, the poems load now, for some reason they only work when I run the page through a local server on my computer (and not when I open the html file normally).

aureliejr commented 1 year ago

fixed the style and committed the other changes i had made