Open andrewscottcohen opened 1 year ago
hey @andrewscottcohen , there are a few issues here preventing me from properly running + testing (&& thus reviewing) ur code, it might have to do with when u pulled from upstream && when u branched off of that to create ur fork. let's try to clean this up so i can pull + test on my end, here's what i suggest (as best as i can tell from here):
git checkout main
&& pull from upstream git pull upstream main
(u may have merge conflicts, take care in resolving those, if u're not confident in that process let me know && we can schedule a time to zoom && do that together), once u've resolved those (which also means committing those changes), push to ur main branch git push origin main
git checkout sentimentHeatmap
&& pull from the class main again git pull upstream main
(u may need to resolve merge conflicts again), once u've resolved those push those updates to ur new branch git push origin sentimentHeatmap
once u do that let me know so i can pull on my end && see if this resolves the strange conflicts i'm getting
@nbriz just pushed the code after fixing the conflicts.
@nbriz Right now the map is showing the density of bus stops in Chicago, not the actual sentiment. I did this to show a visual proof of concept while I waited for the rest api to be finalized so that I could compute sentiment across all poems. I heard your feedback on the backend sentiment function and I think I got that sorted out (could be wrong).
I'd be happy to hop on anytime to discuss the plan moving forward!
@andrewscottcohen just checking in on this, any idea when u think u'll be pushing these updates?
@nbriz I'll try to have it all in by tomorrow night. Do you have time tomorrow to hop on Zoom just to clarify what updates are needed?
@andrewscottcohen sure i'll email u some times
@nbriz I merged the two maps and made the sentiment page. The sentiment function is not currently being read in the frontend.
@andrewscottcohen great!
the integration into the map.html
looks good (don't forget to remove any old files we're not using anymore like sentimentHeatmap.html
&& the sentiment.html
file && accompanying REST API end point are looking good so far let me know if u need any help w/that
@nbriz I'm having difficulty with the sentiment functions... I am getting a 404 error on the API request
@andrewscottcohen in order to use a library (like sentiment.js) u need to first download it using npm install [library]
as they mention in their npm page, judging by ur package.json (which lists all the downloaded/installed "dependencies") i'm guessing u may have missed this step?
@nbriz That's all squared away and I made a few updates to the backend + frontend. I think it should be working now but it still is not. The input text still does not seem to run through the backend function.
thnx @andrewscottcohen, i'm going to mark the assignment as "complete" but i'm going to hold off on merging this since it's still a work in progress