NLog 4.5 support (.NET Standard 2 and structured logging)

net-commons / common-logging

A portable logging abstraction for .NET

http://net-commons.github.io/common-logging

Apache License 2.0

649 stars 205 forks source link

NLog 4.5 support (.NET Standard 2 and structured logging) #159

Open Troncek opened 7 years ago

Troncek commented 7 years ago

Any time-frame for NLog 4.5 wrapper in Common.Logging?

I can use the existing 4.4.12 and change it up a bit, and it works, but an official support would be nice.

Edit: Also, the NLog wrapper WriteInternal method that calls _logger.Log<> doesn't support structured logging functionality with NLog 4.5 beta7, because it fails in string.Format part of code in StringFormatFormattedMessage (AbstractLogger.cs).

gaviriar commented 6 years ago

Hi There, I would also be interested in support for NLog 4.5, is this planned at all?

@Troncek could you please share the code changes you have made?

stevozilik commented 5 years ago

I'm also interested in 4.5 support

Seikilos commented 5 years ago

@Troncek Could you create a pull request for your work? Even if it is a hack, this would allow the devs to review it. Looks like 4.5 is not going to be supported anytime soon here.

snakefoot commented 5 years ago

Created a pull-request: #176 (Includes custom build of nuget-package as attachment)