net-daemon / netdaemon

An application daemon for Home Assistant written in .NET
MIT License
223 stars 64 forks source link

Fix: Registry update fails when Device Model property is an array #1160

Closed FrankBakkerNl closed 2 months ago

FrankBakkerNl commented 2 months ago

Breaking change

Proposed change

Type of change

Additional information

Checklist

If user exposed functionality or configuration are added/changed:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 82%. Comparing base (3713081) to head (ac9608e). Report is 1 commits behind head on main.

Files Patch % Lines
....HassClient/Internal/Json/EnsureStringConverter.cs 85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1160 +/- ## ==================================== Coverage 82% 82% ==================================== Files 190 189 -1 Lines 3782 3777 -5 Branches 423 421 -2 ==================================== + Hits 3116 3121 +5 + Misses 499 491 -8 + Partials 167 165 -2 ``` | [Flag](https://app.codecov.io/gh/net-daemon/netdaemon/pull/1160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=net-daemon) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/net-daemon/netdaemon/pull/1160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=net-daemon) | `82% <85%> (+<1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=net-daemon#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.