net-lisias-ksp / DistantObject

Distant Object Enhancement (DOE) is a visual enhancement mod that makes objects realistically visible over large distances.
Other
10 stars 3 forks source link

show names on mouseover doesnt remember setting #28

Closed a402245 closed 1 year ago

a402245 commented 1 year ago

as per title. set "show names on mouseover" to on and click apply. next time loading the game, the setting is not remembered.

Lisias commented 1 year ago

Thank you very much for the report, @a402245 . And sorry I didn't noticed it sooner.

Github only warns me about being mentioned (i.e., using @Lisias on the text), not when someone opens an issue!

I'm working on it.

Lisias commented 1 year ago

Cross reference: this was also reported on Forum.

Lisias commented 1 year ago

It's not only the "showNames", the "enableFlares" also is being ignored.

It's not a typo, it's some shitty code I wrote that screwed up the settings' loading somehow…

Saving is OK.

Lisias commented 1 year ago

Well.. Nope. Loading is partially working - the debugMode setting is working fine by example.

So the ConfigNode itself is being loaded fine.

I think the problem is on the KSPe's ConfigNodeWithSteroids.HasNode …. :/

Maybe a different misbehaviour from the same bug reported on https://github.com/net-lisias-ksp/KSPe/issues/23 ?

Lisias commented 1 year ago

YES! The same misbehaviour!


[LOG 00:12:11.839] DOE *****
[LOG 00:12:11.840] DistantFlare = DistantFlare
{
}

[LOG 00:12:11.840] DistantVessel = DistantVessel
{
}

[LOG 00:12:11.840] SkyboxBrightness = SkyboxBrightness
{
}
``

The nodes above should be filled with data, but they are empty!
Lisias commented 1 year ago

The issue https://github.com/net-lisias-ksp/KSPe/issues/23 was bogus.

But the KSPe.ConfigNodeWithSteroids still have a bug on the HasNode method. Handling it on https://github.com/net-lisias-ksp/KSPe/issues/40

Lisias commented 1 year ago

Closing this issue, as KSPe.Light.DOE was updated with the fix mentioned above.