search

net-lisias-ksp / DistantObject

Distant Object Enhancement (DOE) is a visual enhancement mod that makes objects realistically visible over large distances.
Other
10 stars 3 forks source link

DistantVessel is also suffering from Duplicated Labels #29

Open Lisias opened 1 year ago

Lisias commented 1 year ago

As reported by Fellow Kerbonaut Krazy1 on Forum.

I probably need to replicate the fix I implemented on DistantFlare to DistantVessel! (Asteroids are "Vessels" on the Game Engine!).

Lisias commented 10 months ago

For reference, the Body phantom labels were fixed on commit https://github.com/net-lisias-ksp/DistantObject/commit/052badaa5648bccabdde00e6f3e2b65206e2dad3

Lisias commented 10 months ago

This one is also related: https://github.com/net-lisias-ksp/DistantObject/commit/cf9800fdabd8a7dfd7c701c5f695b3ac0d22f780

Lisias commented 10 months ago

Uh… wait… There is code to prevent phantom labels for Vessels too since the first release!!!

https://github.com/net-lisias-ksp/DistantObject/blob/b7c27d2686850d9a0a8fa9a549bd1efab6d5fa86/Source/DistantObject/FlareDraw.cs#L714

Lisias commented 10 months ago

Fired up KSP 1.3.1 (quick and dirty), and the thing is working as expected.

Lisias commented 10 months ago

On KSP 1.12.5 the thing appears to be fine too. :/

Lisias commented 10 months ago

Well, I could not reproduce it - but didn't tried with asteroids yet.

Apparently the problem happened when an asteriod was klawed by a vessel, but I didn't checked this one yet.

I removed the bug and added the support tag. I also removed this from a milestone.