net-lisias-ksp / HLAirshipsCore

Mod for KSP that adds lighter than air parts. Core component.
MIT License
4 stars 2 forks source link

Some Parts needs World Stabiliser on [1.4.0 <= KSP <= 1.11.2], and blow up on KSP 1.12.x #2

Closed Lisias closed 2 years ago

Lisias commented 2 years ago

The following parts

Have collider problems that are impacting [1.4.0 <= KSP <= 1.11.2], and are show stoppers on KSP 1.12.x

For [1.4.0 <= KSP <= 1.11.2] installing World Stabiliser is an acceptable work around.

For KSP 1.12.x there's no known work around (WS is useless for this parts). The only short term measure is to temporarily withdraw these parts on KSP 1.12.x until I fix them.

Lisias commented 2 years ago

I completely missed this. The affected parts are still using the DAE format.

Anyway, temporarily deactivating the parts in KSP 1.12.x on commit https://github.com/net-lisias-kspu/HLAirships/commit/709e7e21f0f0c851f9f50d2da420d1e76db4244a

Lisias commented 2 years ago

Breaking news! This problem also affects KSP 1.3.1, but on a different way!!! :)

When launching one of these parts alone, it sinks under the runway, and keep sinking until it hits the water sphere - and so explodes! :D

screenshot56

screenshot57

screenshot60

screenshot61

This behaviour is, essentially, identical to the one I'm getting with KSP 1.12.x - with the difference that on 1.12.x the part goes straight to hell, instead of slowly sinking (the sinking is so hard that anything attached to it is destroyed by impact on the runway on the way down!).

This hints that whatever Squad had implemented on KSP 1.4 to handle something that ended up on the "Jump Jack Effect" (i.e., the part jumping to 1.000 meters more or less) and that was counter-acted by World Stabiliser, now it's no more and we have again a behaviour similar to KSP 1.3.1!

Oukey… Reworking the meshes is, really, the only way.

Lisias commented 2 years ago

Another evidence:

screenshot58

This setup, on KSP 1.12.x, instantly explodes the cockpit by impact on the runway.

Lisias commented 2 years ago

For reference:

The Envelope, Envelope Octo and Envelope Hecto are different sizes from the following mesh:

screenshot63

And this is the Ludo Blimp:

screenshot62

Lisias commented 2 years ago

Things almost perfect. :)

screenshot64

Lisias commented 2 years ago

Perfect! :)

screenshot68

Lisias commented 2 years ago

Closing/Fixed.

Lisias commented 2 years ago

had to rework the assets because they got incompatible with crafts made with the original parts. Now they are 100% compatible (crafts made from previous versions of HLA/KSP/both will now load fine and work the same (apart from blowing up. :) ).

This sample craft was made using the HLAirships 5.3 on KSP 1.4.3, and was loaded later by removing the 5.3 assents and installing Core:

screenshot60

Late implementation on commit https://github.com/net-lisias-ksp/HLAirshipsCore/commit/95e3fc4fa20f11268e6a58b919c560507113da72