net-lisias-ksp / KSP-Recall

Recall for KSP blunders, screw ups and borks.
GNU General Public License v2.0
25 stars 2 forks source link

AttachedOnEditor is not working for SubAssemblies. #35

Closed Lisias closed 2 years ago

Lisias commented 2 years ago

Fellow Kerbonauts Mircea The Young and Aussie Toad Tool found a missed Use Case for AttachedOnEditor: SubAssemblies are being screwed up on use!

This is also happening when merging crafts (see report 3 below).

Reports:

Lisias commented 2 years ago

Not a surprise, on KSP <= 1.8.1 everything works fine. :)

Lisias commented 2 years ago

Marked as an Enhancement, as this is not a bug on TweakScale neither KSP-Recall

Lisias commented 2 years ago

Not a surprise, on KSP <= 1.8.1 everything works fine. :)

By the way, I'm an idiot! Of course on KSP <= 1.8.1 everything works fine, the AttachedOnEditor is only applied on KSP 1.9 and newer!!! :D

Lisias commented 2 years ago

The thing is working. I'm closing this so.

Lisias commented 2 years ago

For the sake of historic accuracy, this issue ended up being a duplicated of https://github.com/net-lisias-ksp/KSP-Recall/issues/32 - but ended up being handled separately because I didn't managed to correctly diagnose the real cause of the problem at that time.