0.4.0.4 is screwing PAW

[Lisias]

Someone is screwing some PAW entries on Flight!

Fellow Kerbonaut Krazy1 reported:

Here's what I'm seeing in flight:

But this is what I see on my rig (KSP 1.12.5 with the latest KSP-Recall):

On Editor

On Flight

[Lisias]

Oukey, Regression Test Fest.

I downgraded KSP-Recall (on KSP 1.12.5 with a minimal install set -- WITHOUT KSPCF, just to made it clear to my future self) to see what I get.

• Test Sesstions
  • Recall 0.4.0.3 worked fine. KSP.log
    • 
  • Recall 0.4.0.4 Borked! KSP.log
    • 

Where "working fine" is the absence of the weird PAW entries reported by Krazy1 above.

[Lisias]

Oukey, my fault.

[Lisias]

When I wrote 0.4.0.3 (being specific, this commit https://github.com/net-lisias-ksp/KSP-Recall/commit/f8afb62c25f7045e44121dc6e8ce81e9bbde7309 ) I initially meant to tie the presence of the PAW's entries to the DebugMode on KSPe's Globals.

One would need to manually edit the Globals file in order to see that PAWs, and I found no problem on cluttering the PAW with these entries while Debugging something. It was a way to visually check what's installed or not, and if the thing is active or not. But I never bothered to check what would happen, as I had something else on the pipeline and the focus was on hidding the PAWs for the common user.

Then this happened, and I realized these PAW entries were being used by some users, and stupidly just tied the PAWs visibility to a new option, normally set to true, and then what I had intended to happen only on DebugMode started to happen to everybody and the kitchen's sink. This naïve commit caused the problem: https://github.com/net-lisias-ksp/KSP-Recall/commit/8389132e21a53abd42aa5575ba790a1c266d54f5 - as dumb as I could get, to tell you the true.

[Lisias]

Implemented on commit https://github.com/net-lisias-ksp/KSP-Recall/commit/ef0f80aeb62e7ca172cf26452ce69bcc2b72cefd