net-lisias-ksp / KourageousTourists

GNU General Public License v2.0
1 stars 1 forks source link

NRE on KT's OnDestroy #10

Open Lisias opened 2 years ago

Lisias commented 2 years ago

Just found this one on KSP 1.12.3 and a few (probably unrelated) add'ons:

[LOG 17:55:47.100] [KourageousTourists] DETAIL: scene: FLIGHT
[ERR 17:55:47.105] [KourageousTourists] ERROR: Got Exception while attempting to access loaded vessels at error:0

[EXC 17:55:47.107] NullReferenceException: Object reference not set to an instance of an object
        FlightGlobals.get_VesselsLoaded () (at <46478292153440df94e04a2a2ddd1062>:0)
        KourageousTourists.KourageousTouristsAddOn.OnDestroy () (at <a6ae0ea7e1eb47eda525b32fba580921>:0)
        UnityEngine.DebugLogHandler:LogException(Exception, Object)
        KSPe.Util.Log.UnityLogDecorator:UnityEngine.ILogHandler.LogException(Exception, Object)
        ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
        UnityEngine.Debug:LogException(Exception)
        KSPe.Util.Log.UnityLogger:logException(String, Exception)
        KSPe.Util.Log.Logger:error(Exception, String, Object[])
        KourageousTourists.Log:error(Exception, String, Object[])
        KourageousTourists.KourageousTouristsAddOn:OnDestroy()

The vessel had no cockpit or crew, it was an probe. I'm probably forgetting to check for this use case.

Lisias commented 1 year ago

Didn't reproduced it on 1.4.3….

Lisias commented 1 year ago

Didn't reproduced on 1.12.3 neither…

Perhaps some interaction with a 3rd party?

I'm keeping this opened just in case,