search

net-ssh / net-scp

Pure Ruby implementation of the SCP protocol
http://github.com/delano/net-scp
MIT License
154 stars 63 forks source link

Alternative approach #3

Closed Flameeyes closed 11 years ago

Flameeyes commented 13 years ago

Here's the alternative approach I told you earlier ;)

delano commented 13 years ago

A couple more questions:

How are you running the tests? I still can't reproduce the problem (with the original code) Do you have the same problem with net-ssh? Any change made here will need to be made to that lib as well as the others (net-sftp etc). Does it fix the problem to simply add $: << '.' to the Rakefile?

Flameeyes commented 13 years ago

I doubt changing Rakefile would solve it, at the best you'd need to fix test_all.rb in the way I mangled alltest, that's about it.

Having the tests in the Rakefile actually makes it easier for Gentoo to package the ebuilds as then it would use the same interface of a bunch of other packages, rather than requiring us to write a function anew to run the tests for net-scp... strangely enough I didn't get similar failures on net-ssh and net-scp, I guess I should look those up again.

delano commented 11 years ago

I finally pulled in the "rake test" task btw. And I've also started signing the net-ssh family of gems btw.