search

net-ssh / net-scp

Pure Ruby implementation of the SCP protocol
http://github.com/delano/net-scp
MIT License
152 stars 62 forks source link

Fix compatiblity with net-ssh 4.0+ #30

Closed voxik closed 6 years ago

voxik commented 7 years ago

This is my rather naive attempt to fix the test suite errors caused by [1]. It would be probably much better, if there was some method hiding this. @mfazekas what would you think about something like "assert_ssh_raises" (although this would not help to fix the "test_download_directory_should_create_directory_and_files_locally" test case).

komidore64 commented 7 years ago

It would be really great to have this addressed. This failure is causing some of our builds to fail.

mfazekas commented 7 years ago

@voxik sorry for the late response this looks good to me 👍 . Can you also add the ruby version bump here so we can see it passing?