search

net-ssh / net-ssh

Pure Ruby implementation of an SSH (protocol 2) client
http://net-ssh.github.io/net-ssh
MIT License
980 stars 444 forks source link

feat: use new ubuntu - jammy in gh actions and vagrant #904

Closed mfazekas closed 1 year ago

mfazekas commented 1 year ago

Fails in ansible install - need to debug 

TASK [building and installing openssh 7.9 (used in forward test)] **************
[388](https://github.com/net-ssh/net-ssh/actions/runs/4396690815/jobs/7699345588#step:12:389)
  fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["sh", "-c", "./configure --prefix=/opt/net-ssh-openssh && make && sudo make install"], "delta":
fwininger commented 1 year ago

Fails in ansible install - need to debug

TASK [building and installing openssh 7.9 (used in forward test)] **************
[388](https://github.com/net-ssh/net-ssh/actions/runs/4396690815/jobs/7699345588#step:12:389)
  fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["sh", "-c", "./configure --prefix=/opt/net-ssh-openssh && make && sudo make install"], "delta":

Can we use OpenSSH 8.9 instead 7.9 to offer more modern support ?

fwininger commented 1 year ago

https://github.com/net-ssh/net-ssh/pull/860

mfazekas commented 1 year ago

Fails in ansible install - need to debug

TASK [building and installing openssh 7.9 (used in forward test)] **************
[388](https://github.com/net-ssh/net-ssh/actions/runs/4396690815/jobs/7699345588#step:12:389)
  fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["sh", "-c", "./configure --prefix=/opt/net-ssh-openssh && make && sudo make install"], "delta":

Can we use OpenSSH 8.9 instead 7.9 to offer more modern support ?

The issue was that 7.9 doesn't install with openssl 3. Ubuntu 22.04 LTS ships with 7.9, so we might be able to just use the builtin, or build 8.9. We needed 7.9 just because with old ubuntu the shipped ones were much older.

mfazekas commented 1 year ago

Update: test now runs but integration tests are failing with these errors:

Finished in 71.234897s, 22.3767 runs/s, 75.0756 assertions/s.
[176](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:177)

[177](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:178)
  1) Error:
[178](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:179)
TestAgent#test_ssh_agent_add_and_remove:
[179](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:180)
OpenSSL::PKey::PKeyError: pkeys are immutable on OpenSSL 3.0
[180](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:181)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_agent.rb:23:in `generate_key!'
[181](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:182)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_agent.rb:23:in `setup'
[182](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:183)

[183](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:184)
  2) Error:
[184](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:185)
TestAgent#test_ssh_agent_add_and_remove_all_identities:
[185](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:186)
OpenSSL::PKey::PKeyError: pkeys are immutable on OpenSSL 3.0
[186](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:187)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_agent.rb:23:in `generate_key!'
[187](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:188)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_agent.rb:23:in `setup'
[188](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:189)

[189](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:190)
  3) Error:
[190](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:191)
TestKeyExchange#test_kex_diffie-hellman-group14-sha1:
[191](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:192)
Net::SSH::Exception: could not settle on kex algorithm
[192](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:193)
Server kex preferences: curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,sntrup761x25519-sha512@openssh.com,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256
[193](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:194)
Client kex preferences: diffie-hellman-group14-sha1
[194](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:195)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/algorithms.rb:410:in `negotiate'
[195](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:196)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/algorithms.rb:383:in `negotiate_algorithms'
[196](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:197)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/algorithms.rb:247:in `proceed!'
[197](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:198)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/algorithms.rb:187:in `accept_kexinit'
[198](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:199)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:210:in `block in poll_message'
[199](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:200)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:190:in `loop'
[200](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:201)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:190:in `poll_message'
[201](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:202)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:227:in `block in wait'
[202](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:203)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:224:in `loop'
[203](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:204)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:224:in `wait'
[204](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:205)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:89:in `initialize'
[205](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:206)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh.rb:255:in `new'
[206](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:207)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh.rb:255:in `start'
[207](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:208)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_key_exchange.rb:9:in `block (2 levels) in <class:TestKeyExchange>'
[208](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:209)

[209](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:210)
  4) Error:
[210](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:211)
TestPassword#test_keyboard_interactive_with_one_failed_attempt:
[211](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:212)
Net::SSH::AuthenticationFailed: Authentication failed for user net_ssh_1@localhost
[212](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:213)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh.rb:272:in `start'
[213](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:214)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_password.rb:32:in `test_keyboard_interactive_with_one_failed_attempt'
[214](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:215)

[215](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:216)
  5) Error:
[216](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:217)
TestPassword#test_keyboard_interactive_with_good_password:
[217](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:218)
Net::SSH::AuthenticationFailed: Authentication failed for user net_ssh_1@localhost
[218](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:219)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh.rb:272:in `start'
[219](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:220)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_password.rb:20:in `test_keyboard_interactive_with_good_password'
Finished in 71.234897s, 22.3767 runs/s, 75.0756 assertions/s.
[176](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:177)

[177](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:178)
  1) Error:
[178](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:179)
TestAgent#test_ssh_agent_add_and_remove:
[179](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:180)
OpenSSL::PKey::PKeyError: pkeys are immutable on OpenSSL 3.0
[180](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:181)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_agent.rb:23:in `generate_key!'
[181](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:182)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_agent.rb:23:in `setup'
[182](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:183)

[183](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:184)
  2) Error:
[184](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:185)
TestAgent#test_ssh_agent_add_and_remove_all_identities:
[185](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:186)
OpenSSL::PKey::PKeyError: pkeys are immutable on OpenSSL 3.0
[186](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:187)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_agent.rb:23:in `generate_key!'
[187](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:188)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_agent.rb:23:in `setup'
[188](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:189)

[189](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:190)
  3) Error:
[190](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:191)
TestKeyExchange#test_kex_diffie-hellman-group14-sha1:
[191](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:192)
Net::SSH::Exception: could not settle on kex algorithm
[192](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:193)
Server kex preferences: curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,sntrup761x25519-sha512@openssh.com,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256
[193](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:194)
Client kex preferences: diffie-hellman-group14-sha1
[194](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:195)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/algorithms.rb:410:in `negotiate'
[195](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:196)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/algorithms.rb:383:in `negotiate_algorithms'
[196](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:197)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/algorithms.rb:247:in `proceed!'
[197](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:198)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/algorithms.rb:187:in `accept_kexinit'
[198](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:199)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:210:in `block in poll_message'
[199](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:200)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:190:in `loop'
[200](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:201)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:190:in `poll_message'
[201](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:202)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:227:in `block in wait'
[202](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:203)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:224:in `loop'
[203](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:204)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:224:in `wait'
[204](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:205)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh/transport/session.rb:89:in `initialize'
[205](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:206)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh.rb:255:in `new'
[206](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:207)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh.rb:255:in `start'
[207](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:208)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_key_exchange.rb:9:in `block (2 levels) in <class:TestKeyExchange>'
[208](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:209)

[209](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:210)
  4) Error:
[210](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:211)
TestPassword#test_keyboard_interactive_with_one_failed_attempt:
[211](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:212)
Net::SSH::AuthenticationFailed: Authentication failed for user net_ssh_1@localhost
[212](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:213)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh.rb:272:in `start'
[213](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:214)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_password.rb:32:in `test_keyboard_interactive_with_one_failed_attempt'
[214](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:215)

[215](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:216)
  5) Error:
[216](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:217)
TestPassword#test_keyboard_interactive_with_good_password:
[217](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:218)
Net::SSH::AuthenticationFailed: Authentication failed for user net_ssh_1@localhost
[218](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:219)
    /home/runner/work/net-ssh/net-ssh/lib/net/ssh.rb:272:in `start'
[219](https://github.com/net-ssh/net-ssh/actions/runs/4438299296/jobs/7789157888?pr=904#step:16:220)
    /home/runner/work/net-ssh/net-ssh/test/integration/test_password.rb:20:in `test_keyboard_interactive_with_good_password'