Closed timriker closed 1 year ago
Hey Tim Sorry for the delay in my review! The code looks good except for some linting issues. Do you want help with the cypress tests?
Sure. I've upgraded my WSL distro to Ubuntu 22.04 so hopefully the tools are more up to date.
Sure. Give it a go and let me know if you get stuck. Happy to help!
Figured I'd give you a hand with the Cypress tests. I've updated them now but there's one issue that I think I've found:
To reproduce:
https://localhost:8443/#m=v&v,3=192.1
https://localhost:8443/#m=v&v,3=192.1
in the location barCompare this:
To this:
If this is fixed I believe the tests will pass. If not I'll have another go at them.
hashes should be working now. search fields should populate, and highlighting should work.
There is still an issue with fields that contain invalid url characters, or comma. I need to do some escaping and unescaping.
Now with uri encode/decode which should handle fields with regex, comma, etc.
column searches fill in from column().search() on draw(). url can reference virtualserver or pool searches. Only the active view will have it's search applied. example pool search:
m=p&q=pool_&0=-
virtualserver search:
m=v&q=-psb&0=-&1=vs_
shadow layers remain the same.
m=v&q=-psb&0=-&1=vs_&virtualserver=/Common/vs_example_HTTPS@lb-example&irule=/Common/sb/Rule_http_log@lb-example