search

netPhotoGraphics / Website

This repository holds the unique items for the netPhotoGraphics website
2 stars 2 forks source link

Update indexpage.php #27

Closed By-oussef closed 4 years ago

By-oussef commented 4 years ago

Add Google Analitycs

sbillard commented 4 years ago

So, it seems you are adding the same code to various scripts. The proper way to do this is to create a plugin that inserts the code and register it to the themehead filter.

Please withdraw this pull request and #26 and prepare a plugin that does this code. (If needed you can limit the pages it loads the code on in the plugin.) Also in your pull request remove the code from the mobile theme as the plugin will handle it.

sbillard commented 4 years ago

YOu can use the themeSwitcher as an example of how to do this. Look at its theme_head handling.

By-oussef commented 4 years ago

THank you

sbillard commented 4 years ago

I have actually implemented and deployed this plugin in the current website. See bf18d196b9a669055d97f540d71feb368f56068e.

With the country effectively shut down, I had time to address it.

By-oussef commented 4 years ago

THank you Stephen