Closed cchen22 closed 1 year ago
Patch coverage has no change and project coverage change: -2.55
:warning:
Comparison is base (
d1d4038
) 53.86% compared to head (419c7ec
) 51.31%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hey @cchen22 , thank you for this great contribution. Can you please transform the readme.md from your repo https://github.com/cchen22/TIGER/blob/master/README.md to a Jupyter notebook and push it as a vignette in netbooks, you can create a PR here: https://github.com/netZoo/netbooks/tree/main/netbooks/netZooR
Hey @cchen22 , thank you for this great contribution. Can you please transform the readme.md from your repo https://github.com/cchen22/TIGER/blob/master/README.md to a Jupyter notebook and push it as a vignette in netbooks, you can create a PR here: https://github.com/netZoo/netbooks/tree/main/netbooks/netZooR
Hi @marouenbg , pull request for the TIGER.ipynb notebook was created: https://github.com/netZoo/netbooks/pull/11. However, for the current pull request of the TIGER.R code, I am a little confused about the "codecov" coverage report issue. Do you have any suggestions?
This is great, thank you @cchen22 ! No problem at all with codecov, it is complaining because we did not provide a test for the function. I need to check a couple of things for the integration and I will get back to you!
Hi @cchen22 , Happy new year! I haven't forgotten about this, I waiting for an older PR to correct an old release, then we add TIGER in.
Hi @marouenbg , Happy new year! Please take your time and let me know if there is any issue with TIGER.
Hey @cchen22 ,
Sorry this took so long, we had a Bioconductor issue that we just fixed. So can you have a final quick look at this before merging into devel?
Also new method contributions have to verify a few points. We have moved to a new phase in netZoo and our goals are to i) increase novelty and diversity of methods, ii) expand to new algorithms and statistical paradigms, and iii) increase the impact of each individual method:
Feel free to reopen when you're ready to proceed!
Hi @marouenbg
Apologies for the delayed response. I have been preoccupied with my graduation requirements this month. I am now ready to incorporate TIGER into netzooR, which I am really looking forward to.
I reviewed your checklist and it seems TIGER meets most of the criteria. I will delete my GitHub repository after merging TIGER into netzooR. I will also be sure to acknowledge netzooR in the TIGER manuscript. Please let me know if there are any specific items I should double-check before merging.
Thank you, Chen
Congrats @cchen22, this is great to hear ! 🥳 Let's resume netZooR integration then
Add TIGER.R from https://github.com/cchen22/TIGER