netanelgilad / meteor-ionic-example

An example app using urigo:ionic package for simple app development with the ionic framwork on meteor.
72 stars 21 forks source link

Update example to define controllers under app #3

Closed Urigo closed 9 years ago

Urigo commented 9 years ago

Please update the example to define the controller under the app module and not the angularMeteor module.

Both work, but putting the controller under the app is best practice.

rubytastic commented 9 years ago

Yes we need MVC and best practices. I started on a project myself also but have not got around it yet https://github.com/pvos/meteor-ionic

Maybe its an idea to combine efforts and try to make a amazing meteor ionic integration?

netanelgilad commented 9 years ago

@Urigo Fixed in https://github.com/netanelgilad/meteor-ionic-example/commit/9fb8e8caac5dc172339092a2329d259b8a9cd831

@rubytastic I'm trying to understand in what your project differs from @Urigo meteor-ionic. Except that our meteor ionic depends on meteor-angular as well which gives you the needed MVC. What features are you feeling are still missing in our meteor-ionic? I'm all about combining efforts! =]

franckbirba commented 9 years ago

hi Netanel, thank you for the answer, more exactly, my href is not working:

here is the template:

and the controller:

.config(function($stateProvider, $urlRouterProvider) { $stateProvider

.state('app', {
  url: "/app",
  abstract: true,
  templateUrl: "templates/menuVoisins.html",
  controller: 'AppCtrl'
})

});

when i click on the item, the url changes as "%23%2Fapp"

i just want to use the left menu to navigate through views. Maybe the templateUrl is the problem, i tried many things, but none of them worked. thanks in advance, regards

2014-12-03 20:44 GMT+01:00 Netanel Gilad notifications@github.com:

Closed #3 https://github.com/netanelgilad/meteor-ionic-example/issues/3.

— Reply to this email directly or view it on GitHub https://github.com/netanelgilad/meteor-ionic-example/issues/3#event-202170425 .

Franck BIRBA Consultant Mobile Indépendant 0770012365

http://www.franckbirba.fr Rejoignez moi sur Viadeo: http://www.viadeo.com/invitation/franck.birba

netanelgilad commented 9 years ago

Ok cool. So this actually relates to https://github.com/Urigo/meteor-ionic/issues/29. @Urigo Any ideas on how we gonna approach this issue? We'll continue discussion there I guess..

Urigo commented 9 years ago

I've commented inside issue #29

franckbirba commented 9 years ago

thank you guys, let me have a look, please tell me if i can help, i would be happy to

regards

2014-12-04 3:17 GMT+01:00 Uri Goldshtein notifications@github.com:

I've commented inside issue #29

— Reply to this email directly or view it on GitHub https://github.com/netanelgilad/meteor-ionic-example/issues/3#issuecomment-65527622 .

Franck BIRBA Consultant Mobile Indépendant 0770012365

http://www.franckbirba.fr Rejoignez moi sur Viadeo: http://www.viadeo.com/invitation/franck.birba

rubytastic commented 9 years ago

Would love to help also but lacking experience in the field of Angular / Ionic. So you have my excitement and commitment also!