Get Credentials and Remove Role Fixes

[mikewiebe]

Summary of Changes:

• Update to allows 'ndfc_switch_username' and 'ndfc_switch_password' credentials to be stored as environment variables or set directly under group_vars and retrieved properly.
• Refactor remove role to generate skip messages at the end to make them more noticeable/readable.

IMPORTANT Once this change goes in we need to revert the following changes again but only AFTER we publish this collection to Galaxy.

https://github.com/netascode/ansible-dc-vxlan-example/commit/2e1a2917b0baab7421f53051f0504b000f70b30d

Additional Details:

Here are the test cases that I executed to verify the credential lookup logic

Using the following information from connection.yaml

---
# Connection Parameters for 'ndfc' inventory group
#
# Controller Credentials
ansible_connection: ansible.netcommon.httpapi
ansible_httpapi_port: 443
ansible_httpapi_use_ssl: true
ansible_httpapi_validate_certs: false
ansible_network_os: cisco.dcnm.dcnm
# NDFC API Credentials
ansible_user: "{{ lookup('env', 'ND_USERNAME') }}"
ansible_password: "{{ lookup('env', 'ND_PASSWORD') }}"

# Credentials for devices in Inventory lookup using ENV vars
ndfc_switch_username: "{{ lookup('env', 'NDFC_SW_USERNAME') }}"
ndfc_switch_password: "{{ lookup('env', 'NDFC_SW_PASSWORD') }}"

# Hard Coded Credentials
ndfc_switch_username: "admin"
ndfc_switch_password: "password"

• Verify user error generated when BOTH ENV var lookup and hard coded lines are commented out
• Verify user error generated with ENV var lookup but ENV vars are NOT set
• Verify successful authentication when either ENV vars are set or info is hard coded
• Verify successful authentication when 'inventory_hostname' is changed

Resolves #111