search

netascode / ansible-dc-vxlan

Ansible Collection for configuring a VXLAN Fabric using Direct to Controller (DTC) or Direct To Device (DTD) workflows.
https://galaxy.ansible.com/ui/repo/published/cisco/nac_dc_vxlan/
MIT License
6 stars 6 forks source link

Description of Create vs. Deploy role incorrect #135

Closed marehler closed 2 months ago

marehler commented 2 months ago

Referring to "Understanding our Ansible roles" in the collection README/documentation, I think the description of the Create and Deploy role is not entirely correct. The documentation says "The deploy role is going to deploy those changes to the NDFC controller. [...] This is the role that is going to make the changes in the NDFC controller."

However, I observe the Create role already applies the changes to the NDFC controller. The Deploy role applies the changes to the switches.

https://github.com/netascode/ansible-dc-vxlan https://galaxy.ansible.com/ui/repo/published/cisco/nac_dc_vxlan/docs/

marehler commented 2 months ago

Please find my review comments in PR #140.