search

netascode / ansible-dc-vxlan

Ansible Collection for configuring a VXLAN Fabric using Direct to Controller (DTC) or Direct To Device (DTD) workflows.
https://galaxy.ansible.com/ui/repo/published/cisco/nac_dc_vxlan/
MIT License
6 stars 6 forks source link

Add Test Checks for NDFC Connectivity & Authorization #145

Closed mtarking closed 1 month ago

mtarking commented 2 months ago

This PR resolves #104 Add test checks for NDFC & Switch connectivity & authorization in the validate role after schema and rule tests.

Need to determine if we want a control knob to turn these connectivity and auth tests on & off.

rrahimm commented 2 months ago

@mtarking

i believe we should have control knobs to turn these on/off.

There could be the scenario, where our solution will just be provided access to NDFC alone (as that is enough to run the solution). So, the tests towards Switches directly would fail.

So, we may have a default of Checking NDFC and not checking switches, and allow users to control with flags.

juburnet commented 1 month ago

@mtarking I reviewed this. Perhaps we should break this PR into 2 pieces. It works well for the ndfc checks. It succeeds when all is good, and it fails for timeout and for authentication issues.

For the switch tests I'm unable to do a successful test because my laptop/Ansible doesn't have access to the switches directly. I agree with previous comments that the control knob is required for switches. For DTC we ideally want to test connectivity and credentials from the NDFC. Not sure if it's possible, or if we want to basically do a discovery and see what's manageable.

If we split this PR, we could go ahead and implement the NDFC checks. Otherwise, we need the controls for switches, with a default of false, before we implement.

mtarking commented 1 month ago

@juburnet please review again as I checked a few things with the NDFC check. Thanks.