search

netascode / ansible-dc-vxlan

Ansible Collection for configuring a VXLAN Fabric using Direct to Controller (DTC) or Direct To Device (DTD) workflows.
https://galaxy.ansible.com/ui/repo/published/cisco/nac_dc_vxlan/
MIT License
6 stars 6 forks source link

Integration tests for the fabric creation #147

Closed devegupt closed 1 month ago

devegupt commented 2 months ago

This PR includes full data profile for fabrics configuration as below:

  1. fabric_full_small_ospf_multicast_asm_example
  2. fabric_full_small_ospf_multicast_bidir_example
  3. fabric_full_small_ospf_ingress_example
  4. fabric_full_small_isis_multicast_asm_example
  5. fabric_full_small_isis_multicast_bidir_example
  6. fabric_full_small_isis_ingress_example
juburnet commented 1 month ago

@devegupt @mtarking - to reduce a little duplication, lets remove fabric_full_small_ospf_multicast_asm_example since it already exists as part of fabric_full_small_example

mtarking commented 1 month ago

I think it might be better to keep @devegupt's with the more descriptive name and replace the existing.

juburnet commented 1 month ago

I think it might be better to keep @devegupt's with the more descriptive name and replace the existing.

That would be fine. We have been using fabric_full_small as the generic template, just like we have the generic fabric_full_large. Either way would be fine.

devegupt commented 1 month ago

I think it might be better to keep @devegupt's with the more descriptive name and replace the existing.

That would be fine. We have been using fabric_full_small as the generic template, just like we have the generic fabric_full_large. Either way would be fine.

@juburnet @mtarking I have removed the fabric_full_small_example fabric profile including all the references related to this in the test_inventory.yml and test_update_model_data_yml. Since we have the same configuration in fabric_full_small_ospf_multicast_asm.