netascode / terraform-aci-nac-aci

Terraform Cisco ACI Nexus-as-Code Module
https://registry.terraform.io/modules/netascode/nac-aci/aci
Apache License 2.0
21 stars 25 forks source link

Ignore NDO annotation changes on L3Outs #103

Closed andbyrne closed 4 months ago

andbyrne commented 4 months ago

There are two options to configure L3Outs with NDO:

  1. The legacy option defines the L3Out and associated VRF with the remainder of the configuration applied via the APIC
  2. The new option defines the entire L3Out in NDO

The second option is not yet supported in Terraform, and therefore most people will use the first option.

Each time the template containing the L3Out is deployed by NDO, the annotation on the l3extOut and l3extRsEctx objects is changed to orchestrator:msc-shadow:no.

The next time the configuration is applied to the APIC it will change the annotation back to whatever has been defined in the aci provider configuration.

This causes unnecessary ongoing changes. This PR implements a workaround to ignore annotation changes on these two objects. It should remain in place until the terraform-mso-nac-ndo module and mso provider support the full configuration of L3Outs in NDO.

github-actions[bot] commented 4 months ago

Integration Test Results

1 tests   - 7   0 :white_check_mark:  - 8   0s :stopwatch: ±0s 1 suites ±0   0 :zzz: ±0  1 files   ±0   0 :x: ±0   1 :fire: +1 

For more details on these errors, see this check.

Results for commit 51f8613d. ± Comparison against base commit 1907ab66.