search

netascode / terraform-aci-nac-aci

Terraform Cisco ACI Nexus-as-Code Module
https://registry.terraform.io/modules/netascode/nac-aci/aci
Apache License 2.0
21 stars 24 forks source link

Attach the route summarization policy under L3Out Ext EPG #120

Closed devegupt closed 4 months ago

devegupt commented 4 months ago

Adding support to attach the route summarization policy under L3Out External EPG Subnet

andbyrne commented 4 months ago

This appears to be a breaking change. The original schema should be retained, and continue to apply the default policy from the common tenant if no policy is specified in the new bgp_route_summarization_policy attribute.

devegupt commented 4 months ago

This appears to be a breaking change. The original schema should be retained, and continue to apply the default policy from the common tenant if no policy is specified in the new bgp_route_summarization_policy attribute.

Sounds good, I am working on this.

devegupt commented 4 months ago

This appears to be a breaking change. The original schema should be retained, and continue to apply the default policy from the common tenant if no policy is specified in the new bgp_route_summarization_policy attribute.

I have pushed the updates and original schema is retained in this PR. As per the new logic:

  1. If "bgp_route_summarization" is set to 'true' and "bgp_route_summarization_policy" is not defined, 'default' route summarization policy will be added.
  2. If "bgp_route_summarization" is set to 'true' and "bgp_route_summarization_policy" is defined, custom policy name will be added.
  3. If "bgp_route_summarization" is set to 'false' and "bgp_route_summarization_policy" is defined, no policy will be added.
  4. If "bgp_route_summarization" is set to 'false' and "bgp_route_summarization_policy" is not defined, no policy will be added.
devegupt commented 4 months ago

This appears to be a breaking change. The original schema should be retained, and continue to apply the default policy from the common tenant if no policy is specified in the new bgp_route_summarization_policy attribute.

done

juchowan commented 4 months ago

please also run pre-commit

devegupt commented 4 months ago

please also run pre-commit

Done