search

netascode / terraform-aci-nac-aci

Terraform Cisco ACI Nexus-as-Code Module
https://registry.terraform.io/modules/netascode/nac-aci/aci
Apache License 2.0
20 stars 24 forks source link

Module 8 fix l3out #128

Closed dtatsumi-c closed 2 months ago

yoshaseg-451861 commented 3 months ago

@andbyrne

Can you please also add the same fix for the export route map?

Do you mean outbound_route_map? Since outbound_route_map is a mandatory setting, we are only targeting inbound_route_map. Should we fix the outbound_route_map as well?

andbyrne commented 3 months ago

@andbyrne

Can you please also add the same fix for the export route map?

Do you mean outbound_route_map? Since outbound_route_map is a mandatory setting, we are only targeting inbound_route_map. Should we fix the outbound_route_map as well?

Both are optional in the module's variables.tf file. Please apply the same fix to both.

yoshaseg-451861 commented 3 months ago

@andbyrne

Can you please also add the same fix for the export route map?

Do you mean outbound_route_map? Since outbound_route_map is a mandatory setting, we are only targeting inbound_route_map. Should we fix the outbound_route_map as well?

Both are optional in the module's variables.tf file. Please apply the same fix to both.

@andbyrne

Understood, We will apply the fix to outbound as well.

yoshaseg-451861 commented 2 months ago

@andbyrne

The fix has also been applied to outbound. Please review the changes.