search

netascode / terraform-aci-nac-aci

Terraform Cisco ACI Nexus-as-Code Module
https://registry.terraform.io/modules/netascode/nac-aci/aci
Apache License 2.0
18 stars 14 forks source link

Autogeneration of LF/SPINE fabric/access profiles fails when suffix is added #20

Closed alexanderdeca closed 9 months ago

alexanderdeca commented 9 months ago

For example, in the aci_fabric_policies.tf module "aci_fabric_leaf_switch_profile_auto" (starting code line 368), the replace statement does not account for when a suffix is added in the default values for autogenerating fabric/access leaf/spine profiles, etc.

Working "LEAF\g" -> output is LEAF1001, LEAF1002 etc.. Not working "LEAF\g_SwPro" -> output is LEAF

Expected behaviour is to account for suffixes added to the naming

danischm commented 9 months ago

Thanks for raising the issue! This has already been fixed (https://github.com/netascode/terraform-aci-nac-aci/commit/c4be586c33f570dc408118bed8b0602b4bc4e14c) and will be included in the next release.

alexanderdeca commented 8 months ago

Hi,

Any update on when the new release will be available ?

Thanks

Alexander

From: Daniel Schmidt @.> Date: Monday, 2 October 2023 at 10:02 To: netascode/terraform-aci-nac-aci @.> Cc: Alexander Deca @.>, Author @.> Subject: Re: [netascode/terraform-aci-nac-aci] Autogeneration of LF/SPINE fabric/access profiles fails when suffix is added (Issue #20)

Closed #20https://github.com/netascode/terraform-aci-nac-aci/issues/20 as completed.

— Reply to this email directly, view it on GitHubhttps://github.com/netascode/terraform-aci-nac-aci/issues/20#event-10523076144, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEAJEUKC3MPSVDQY36BXCELX5JYJBANCNFSM6AAAAAA5PA4V6Y. You are receiving this because you authored the thread.Message ID: @.***>

danischm commented 8 months ago

We are aiming for end of October, beginning of November.

alexanderdeca commented 7 months ago

Hey Daniel,

Any update on the drop for the new release? 😊

thanks

From: Daniel Schmidt @.> Date: Monday, 16 October 2023 at 10:05 To: netascode/terraform-aci-nac-aci @.> Cc: Alexander Deca @.>, Author @.> Subject: Re: [netascode/terraform-aci-nac-aci] Autogeneration of LF/SPINE fabric/access profiles fails when suffix is added (Issue #20)

We are aiming for end of October, beginning of November.

— Reply to this email directly, view it on GitHubhttps://github.com/netascode/terraform-aci-nac-aci/issues/20#issuecomment-1763944361, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEAJEUIJCMQWE2U6VGFFW5LX7TTFXAVCNFSM6AAAAAA5PA4V62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTHE2DIMZWGE. You are receiving this because you authored the thread.Message ID: @.***>

danischm commented 7 months ago

We are working towards it. It should be ready by end of this week or latest next week. If you want to test the latest enhancements, you can always source the module directly from git:

module "aci" {
  source = "github.com/netascode/terraform-aci-nac-aci.git?ref=main"

  ...
}
alexanderdeca commented 7 months ago

Thanks!

From: Daniel Schmidt @.> Date: Tuesday, 7 November 2023 at 11:08 To: netascode/terraform-aci-nac-aci @.> Cc: Alexander Deca @.>, Author @.> Subject: Re: [netascode/terraform-aci-nac-aci] Autogeneration of LF/SPINE fabric/access profiles fails when suffix is added (Issue #20)

We are working towards it. It should be ready by end of this week or latest next week. If you want to test the latest enhancements, you can always source the module directly from git:

module "aci" {

source = "github.com/netascode/terraform-aci-nac-aci.git?ref=main"

...

}

— Reply to this email directly, view it on GitHubhttps://github.com/netascode/terraform-aci-nac-aci/issues/20#issuecomment-1798195112, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEAJEUNT4HYDV2OQ4PW5LRLYDICAHAVCNFSM6AAAAAA5PA4V62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGE4TKMJRGI. You are receiving this because you authored the thread.Message ID: @.***>