search

netatoo / phoenix-theme

Dark & Light custom UI themes with colors variations for Sublime Text 2
890 stars 61 forks source link

Fix duplicate sidebar icons. #37

Closed kristijanhusak closed 10 years ago

kristijanhusak commented 10 years ago

This is the fix for the issue https://github.com/netatoo/phoenix-theme/issues/36

It removes duplicate folder icons in the sidebar.

darylknight commented 10 years ago

Thanks kristijanhusak, works perfectly :)

kristijanhusak commented 10 years ago

@lanthaler isn't that the default ?

Dark theme = dark sidebar and tabs, Light theme = light sidebar and tabs.

lanthaler commented 10 years ago

@kristijanhusak Sorry for the delay. I use the light theme but nevertheless I got a black sidebar and tabs (with black text and thus completely unreadable).

kristijanhusak commented 10 years ago

@lanthaler check if you spelled theme name right in the configuration.

lanthaler commented 10 years ago

I spelled it right. Also, reverthing the changes in Phoenix Light.sublime-theme fixed the problem.

kristijanhusak commented 10 years ago

What ST version are you using ?

lanthaler commented 10 years ago

2.0.2, Build 2221

kristijanhusak commented 10 years ago

Well this is the fix for the latest build for version 3. You'll need to update ST to the latest version or delete this portion of code.

lanthaler commented 10 years ago

Then perhaps the README should be updated to say that compatibility to ST2 isn’t a goal anymore.. Currently it says: “Dark & Light custom UI themes with colors variations for Sublime Text 2”. I do hope however that compatibility with ST2 will be persevered at least for some time (after ST 3's first stable version is released).

kristijanhusak commented 10 years ago

Yea i understand, but i don't think it's possible to have support for both v2 and v3 in the same branch. Try asking from @netatoo to create a separate branch and then you can use that, but not from package control unfortunately.

lanthaler commented 10 years ago

Just thinking out loud but wouldn’t the simplest thing be to just add a file specifically for ST2? Something like “Phoenix Light ST2.sublime-theme”?

kristijanhusak commented 10 years ago

Yea, thats a good idea. Create a PR and he will probably merge it in.

lanthaler commented 10 years ago

OK, took me a while but I just filed PR #43. Apparently it is just the trailing comma that is confusing ST2.