search

netbe / Babelish

Chaotically confused, like Babel
http://netbe.github.io/Babelish
MIT License
253 stars 84 forks source link

Fixed issue #51 and #52 #71

Closed Neoklosch closed 8 years ago

Neoklosch commented 9 years ago

Fixed issue #51 and also #52. Both errors are very similar and have the same reason. To solve the problem I'm no longer using xmlsimple. After merging all of my pull requests it's also possible to remove xml-simple from the gemspec file.

Additionally to my changes I created a unittest to verify the functionality of my changes.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.02%) to 88.1% when pulling 2bc95878d8f61495a1365de502283815abb5694f on Neoklosch:fix-51 into f98c502ed2c7962cb18b4882eaf43d9c679c9dc0 on netbe:master.

netbe commented 9 years ago 
 After merging all of my pull requests it's also possible to remove xml-simple from the gemspec file.

@Neoklosch then can you remove it from gemspec on that pull request now?

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-64.82%) to 23.26% when pulling d3a9fd4684d6edf6118139726d89bc345818e36d on Neoklosch:fix-51 into f98c502ed2c7962cb18b4882eaf43d9c679c9dc0 on netbe:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 88.08% when pulling 1f7673fc98bbab003640bea74f20af955ff55175 on Neoklosch:fix-51 into f98c502ed2c7962cb18b4882eaf43d9c679c9dc0 on netbe:master.

netbe commented 9 years ago

@Neoklosch see @houndci comments