Open safouman opened 3 years ago
Greetings,
in the getColorEncoding function:
if ((c.r + c.g + c.b) && typeof (c.r + c.g + c.b) === 'number')
in the above conditions and its similar in the code if r, g, b are zero rgb(0,0,0) , {r:0,g:0,b:0} the result will be falsy cause 0 && true equals false
rgb(0,0,0) , {r:0,g:0,b:0}
would be great to verify the edge cases in each function
Greetings,
in the getColorEncoding function:
if ((c.r + c.g + c.b) && typeof (c.r + c.g + c.b) === 'number')in the above conditions and its similar in the code if r, g, b are zero
rgb(0,0,0) , {r:0,g:0,b:0}the result will be falsy cause 0 && true equals falsewould be great to verify the edge cases in each function