netbeast / colorsys

:art: Minimalistic color converter for RGB, HSV, HSL, CMYK, HEX and CSS strings
http://getyeti.co
MIT License
57 stars 16 forks source link

Bug in hsv2Rgb #6

Closed ghost closed 8 years ago

ghost commented 8 years ago

When the argument passed to the object it encounters an error.

jsdario commented 8 years ago

I cannot reproduce the bug, can you please be more explicit? This is what I tried:

colorsys.hsv2Rgb({ h: 0 , s: 0 , v: 100 })
{ r: 255, g: 255, b: 255 }
ghost commented 8 years ago

Bagh version of npm. There is such a tape (and not only in hsv2Rgb): colorsys.hsv2Rgb = function (h, s, v) { if (typeof h === 'object') { const args = r h = args.h; s = args.s; v = args.v; }

jsdario commented 8 years ago

Thanks @Pshoniuk for the hint. I already have republished and added some scripts in package.json to make it easier for contributors to update the npm and bower packages.