search

netbirdio / netbird

Connect your devices into a secure WireGuard®-based overlay network with SSO, MFA and granular access controls.
https://netbird.io
BSD 3-Clause "New" or "Revised" License
10.5k stars 472 forks source link

Route identity character limit increase #1262

Open kent-hydra opened 10 months ago

kent-hydra commented 10 months ago

Is your feature request related to a problem? Please describe. Attempting to use Netbird with a multi-tenant / multi-regional architecture, so having the network routes named with enough identifying information is essential. Currently naming looks something like "Company ABC - Region A - Group 1 - Management" which would put us over the character limit and return an error such as {"message":"identifier should be between 1 and 40","code":422}

Describe the solution you'd like Increase in the number of characters allowed for network_id on the routes objects.

Describe alternatives you've considered We considered slimming it down by using slugs. This may work in the short term, but 40 characters is not very much and we may still run into the limits later on depending on org/region names. Its also not as pretty.

mlsmaycon commented 10 months ago

Hello @kent-hydra, currently, we are limiting to 40 characters only in the network ID, but for the description have 255 characters, would it be better option for you to use slugs for network_id and full names in the description?

kent-hydra commented 10 months ago

Ah I do see the description field when creating routes, although I do not see it when viewing in the UI. This could potentially work if it was visible.

image