netbirdio / netbird

Connect your devices into a secure WireGuard®-based overlay network with SSO, MFA and granular access controls.
https://netbird.io
BSD 3-Clause "New" or "Revised" License
10.73k stars 483 forks source link

if the client runs a dns it cause an error in netbird #1799

Open lfarkas opened 5 months ago

lfarkas commented 5 months ago

We run the latest version of netbird clients v0.27.0. Some of our netbird clients run a bind/named dns on the host. Even if named listen only on other interfaces (ie not on wt0) on these peers the log contains such and error message:

2024-04-04T22:49:01+02:00 WARN client/internal/dns/server.go:317: the DNS manager of this peer doesn't support custom port. Disabling primary DNS setup. Learn more at: https://docs.netbird.io/how-to/manage-dns-in-your-network#local-resolver
2024-04-04T22:49:01+02:00 ERRO client/internal/dns/server.go:323: unable to parse ip address, error: ParseAddr(""): unable to parse IP

in /etc/netbird/config.json the dns setting is (as it's generated): "CustomDNSAddress": "",

braginini commented 5 months ago

Hey @lfarkas Could you please elaborate on what is exactly the issue? DNS doesn’t work on these machines?

lfarkas commented 5 months ago

the strange thing it's working, but i assume if on a well configured machine i've got an error in the log file it seems to me a bug. or at least should have to be fixed.

braginini commented 5 months ago

That rather has to be a warning or not logged at all, as NetBird tries to parse nonexistent DNS. We will have a look. Thanks for reporting!