Refactor firewall manager check - Githubissues

netbirdio / netbird

Connect your devices into a single secure private WireGuard®-based mesh network with SSO/MFA and simple access controls.

https://netbird.io

BSD 3-Clause "New" or "Revised" License

9.87k stars 428 forks source link

Refactor firewall manager check #2054

Closed mlsmaycon closed 1 month ago

mlsmaycon commented 1 month ago

Describe your changes

Some systems don't play nice with a test chain, so we dropped the idea, and instead, we just checked for the filter table

With this check, we might face a case where iptables is selected once, and on the next netbird up/down, it will go back to using nftables

Issue ticket number and link

Checklist

[x] Is it a bug fix
[ ] Is a typo/documentation fix
[ ] Is a feature enhancement
[x] It is a refactor
[ ] Created tests that fail without the change (if possible)
[ ] Extended the README / documentation, if necessary