search

netbirdio / netbird

Connect your devices into a secure WireGuard®-based overlay network with SSO, MFA and granular access controls.
https://netbird.io
BSD 3-Clause "New" or "Revised" License
10.92k stars 494 forks source link

Can't delete empty group due to revoked setup key ? #2561

Closed R-Nabil closed 1 month ago

R-Nabil commented 1 month ago

Describe the problem

Fairly simple : you create a setup-key assigned to a group. Then you revoke that setup key, and actually want to get rid of this group as well. However, you can't get rid of the group as the setup-key, even revoked, is considered part of the group.

To Reproduce

See above

Expected behavior

Be able to delete group with unused setup keys.

Are you using NetBird Cloud?

Yes but similar in selfhosted.

NetBird version

Not sure if relevant here but : 0.28.9

Screenshots

image
pascal-fischer commented 1 month ago

Hi @R-Nabil, this is how the system works right now. I do see the point that it is not particularly user-friendly. I will put this as a feature request for us to think about ignoring it for revoked keys and do the cleanup automatically on group deletion.

R-Nabil commented 1 month ago

I’ve tried to use the API to reassign the keys to a different group (temporary workaround).

Would this group eventually be deleted when those keys expired ? Can I expire them through the API ? On 9 Sep 2024 at 14:07 +0200, pascal-fischer @.***>, wrote:

Hi @R-Nabil, this is how the system works right now. I do see the point that it is not particularly user-friendly. I will put this as a feature request for us to think about ignoring it for revoked keys and do the cleanup automatically on group deletion. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

pascal-fischer commented 1 month ago

You don't need to reassign them, if you just clear the groups a key can belong to no group. Groups will not be deleted if the keys are revoked. You can expire keys over the API, yes.

R-Nabil commented 1 month ago

It actually seems pretty obvious now that you say it :) Thank you ! On 9 Sep 2024 at 14:17 +0200, pascal-fischer @.***>, wrote:

You don't need to reassign them, if you just clear the groups a key can belong to no group. Groups will not be deleted if the keys are revoked. You can expire keys over the API, yes. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>