netbirdio / netbird

Connect your devices into a secure WireGuard®-based overlay network with SSO, MFA and granular access controls.
https://netbird.io
BSD 3-Clause "New" or "Revised" License
11.01k stars 505 forks source link

Self-hosted instance, user registration disabled, users can still register #2749

Open Gauss23 opened 2 weeks ago

Gauss23 commented 2 weeks ago

Describe the problem

Hi, just installed the newest self-hosted version with Zitadel 2.54.10. Disabled the user registration in Zitadel admin but users are still able to register.

To Reproduce

Steps to reproduce the behavior:

  1. Install with getting-started script
  2. login to Zitadel
  3. disable user registration
  4. the button to register is gone from the login page, but go to https://INSTANCE-URL/ui/login/register
  5. and register
  6. in Zitadel you'll see the user.

Expected behavior

User registration should stop working

Are you using NetBird Cloud?

No

NetBird version

0.30.2

Gauss23 commented 2 weeks ago

Just checked at Zitadel and it seems that this is a known bug: https://github.com/zitadel/zitadel/issues/8123

v1rusnl commented 2 weeks ago

Fix is released with Zitadel 2.62.7

Is it safe to upgrade Zitadel?

hnkl commented 1 week ago

Fix is released with Zitadel 2.62.7

Is it safe to upgrade Zitadel?

i tested it in a lab environment. i don't see any difference after the update except that the registration no longer works.

I was still able to log in to Netbird and co.

v1rusnl commented 1 week ago

Fix is released with Zitadel 2.62.7 Is it safe to upgrade Zitadel?

i tested it in a lab environment. i don't see any difference after the update except that the registration no longer works.

I was still able to log in to Netbird and co.

Can confirm this now. Upgraded to 2.64.1 with no issues.

v1rusnl commented 1 week ago

Latest 0.30.3 release still refers to Zitadel 2.54.10 in docker-compose.yml. Any reasons for that? I think https://github.com/zitadel/zitadel/pull/8782 is a pretty important bugfix.